ext/phar: improve .phar madic directory preservation logic in phar::addEmptyDir()#22146
Open
LamentXU123 wants to merge 1 commit into
Open
ext/phar: improve .phar madic directory preservation logic in phar::addEmptyDir()#22146LamentXU123 wants to merge 1 commit into
LamentXU123 wants to merge 1 commit into
Conversation
Girgias
approved these changes
Jun 1, 2026
Contributor
Author
|
I will try to merge this myself to the 8.4 and 8.5 branch tomorrow since this is quite a decided fix. I will take this as an opportunity to learn php's merging workflow :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22011 targeting 8.4. cc @Girgias we also need to merge this into 8.5 :)